docs: clarify placeholder values in custom_domain_mapping example #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasnt
requested changes
Apr 1, 2025
Contributor
|
you can't run /gcbrun in an approval? (trying it in a comment to re-run) |
niharika-98
pushed a commit
to niharika-98/terraform-docs-samples
that referenced
this pull request
Sep 7, 2025
…rraform-google-modules#833) * docs: clarify placeholder values in custom_domain_mapping example * docs: clarify placeholder usage without breaking sample --------- Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/372570764
Changes in documentation: cl/742799018
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/run/docs/mapping-custom-domains#map
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review